Fix issue undefined is not an object evaluating r.default

[ebaynaud]

Fix aksonov/react-native-router-flux#3124

Please provide enough information so that others can review your pull request:

Motivation

Release builds fails without these changes

Test plan

No more errors

Code formatting

Simple letter put from uppercase to lowercase

Changelog

Not required I guess

[react-navigation-ci]

NavigationPlayground for ddcce38 has been deployed.

https://expo.io/@react-navigation-ci/NavigationPlayground?release-channel=ddcce38fa23b2c4662b71401f796f1415b450308

[ericvicenti]

I'm confused why this would fix anything.. what bundler are you using?

[ebaynaud]

Standard metro bundler... I do not know what really happens as you can see in aksonov/react-native-router-flux#3124 but what I'm sure of is that it fixes the encountered issue for me and other people!

[brentvatne]

thanks for submitting a pr! although this seems to fix your problem, i'm hesitant to land something that works without any reason that anyone can understand. it seems more like a bug in another tool.

[ebaynaud]

I understand @brentvatne but it's a really minor change that could avoid me and others folks still using react-native-router-flux to fork react-navigation. That's the only workaround found yet...

[brentvatne]

sorry unless someone can explain why this fixes the problem we cannot land it. the diff on its own makes no sense

[TwilightOwl]

@brentvatne https://babeljs.io/docs/en/babel-plugin-transform-class-constructor-call
This babel plugin is removed from babel 7, therefore your module doesn't work in React Native 0.56 in some cases. Now creating instance without 'new' keyword is impossible. So use 'tabRouter' instead 'TabRouter' or use new with 'TabRouter'

[ebaynaud]

We have now our root cause, could we merge? :)

[martincarrera]

Please @brentvatne could you reopen this PR? Thanks.

[brentvatne]

thanks! yes

[rishiankush]

I updated my react-navigation package with this above fix in all the files:
src/navigators/DrawerNavigator.js
src/navigators/StackNavigator.js
src/navigators/TabNavigator.js

but still getting the same issue in release mode:
Unhandled JS Exception: TypeError: undefined is not an object (evaluating 'r.default')

[brentvatne]

cc @ebaynaud

[jinwuu]

I solved the same issue by: facebook/react-native#20150, Workaround 2

[abartolo]

@ebaynaud Thanks for the fix. I am now able to compile release build successfully.

@rishiankush Did you update all files? I see 4 files are changed but you only mentioned 3.

cc: @brentvatne

[brentvatne]

if someone can confirm that this works as expected i can land it and publish an update to 1.x

[abartolo]

@brentvatne I can confirm this is working. I have been building release builds for IOS and Android using the following "git+https://github.com/ebaynaud/react-navigation#1.x" in my package.json for about 3 weeks now.

[luco]

I'm getting this on v2 as well.

[brentvatne]

please create a new issue and follow the template @luco