0.57.2 Discussion

[kelset]

Conversation on this thread are limited to 0.57.2 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.57.3 release in the near future.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.1 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

[kelset]

Current situation:

• there seems to be one issue related to the babel preset error: bundling failed: Error: Unable to resolve module ./../react-transform-hmr/lib/index.js facebook/react-native#21490 (but a minor release of the preset should fix)

• Xcode 10 is still not fully supported, but there is a PR actively trying to get to a backward compatible solution Fix Xcode 10 errors relating to third-party facebook/react-native#21458

[kelset]

@ChrisEdson, @cristeahub thanks for the feedback on that but please let's try to keep the conv around commits and cherry picks ;)

(the reason why my comment describes the situation is because I want to tunnel people that may end up in this issue to those links instead of writing stuff here ;D )

[ikesyo]

I want the following to be cherry-picked:

• iOS: fix the baseline issue when displaying a mixture of different-language characters facebook/react-native@c1561ab

[radeno]

• Metro 0.48 / HMR fix facebook/react-native@bd8b942
• RCTNetInfo dealloc fix facebook/react-native@e7e63fd
• Fix Android getPhotos crash facebook/react-native@4768bea
• Maybe FBJS 1.0? facebook/react-native@ee03459

[kelset]

Thanks @radeno for the suggestions! Regarding FBJS I'd prefer to avoid it because it's not directly fixing anything AFAIK (and that package itself is, by self admission, not directly for OSS).

A few more commits I want to see cherry picked:

• Fix accessibility role/label facebook/react-native@fa6035b
• Fix artifacting on RN-drawn borders with asymmetric radii facebook/react-native@9e65223
• Resolve protocol http, https when not in lowercase facebook/react-native@d00bdb9
• React sync for revisions ade5e69...d836010 facebook/react-native@7142e9b
• When converting arguments JS->Java, handle integers correctly facebook/react-native@bb9b9a8

[radeno]

@kelset you are right about FBJS.

I don't like fix to http/https protocol. (facebook/react-native@d00bdb9) It is Android specific, but fix code appears on React Native side, not Android side. That commit smells.

Android have from API v16 (which is minimal SDK for 0.57 right?) normalization method: https://developer.android.com/reference/android/net/Uri.html#normalizeScheme()
Need change one line https://github.com/facebook/react-native/blob/1151c096dab17e5d9a6ac05b61aacecd4305f3db/ReactAndroid/src/main/java/com/facebook/react/modules/intent/IntentModule.java#L82 Maybe it is time for my first PR

Update:
PR open: facebook/react-native#21561

[kelset]

Yeah I agree with your assessment @radeno, go for it 👍

[fungilation]

I don't claim to know the internal release workings of React, but is it wise for RN to be often syncing with their alpha versions? 16.6.0-alpha.400d197 in @kelset's linked PR.

[kelset]

I share your concern of moving to an alpha dep, but considering that most likely there won't be another sync commit until after ReactConf (Oct 25th) IF testing goes well I'd prefer to allow people to be able to a update to a version of RN that allows them to use 16.5.2 (which is currently not the case).

And we are not often using alpha versions.

[elicwhite]

I'd like to get this commit picked to add a deprecation warning to ListView: facebook/react-native@e90f5fa

[radeno]

Another fixes:

• Xcode 10 simulator list Fix facebook/react-native@1031872
• FlatList legacyImplementation performance issue warning facebook/react-native@3aa8f09
• Switch component deprecate warning facebook/react-native@997f382
• Fix Adndroid scheme protocol facebook/react-native@4b6f02e fixing previous commit facebook/react-native@d00bdb9

[kelset]

thanks for the links! I'm just waiting for this to land facebook/react-native#21570 (which I think it's simply a matter of some automated process to complete) and I'll proceed to cherry pick & test 💪

[kelset]

Yes, it's OT for this issue so I've opened via GitHub a dedicated issue, see #47 - we can discuss about it there.

[kelset]

Ok, the two commits I was waiting for landed, this should be the full list of commits we'll cherry pick:

• Fix accessibility role/label
• Dealloc first time RCTNetInfo reachability callback
• iOS: fix the baseline issue when displaying a mixture of different-language characters
• Fix artifacting on RN-drawn borders with asymmetric radii
• React sync for revisions ade5e69...d836010
• When converting arguments JS->Java, handle integers correctly
• Fix CameraRoll.getPhotos() crash on Android if device has a problematic video asset
• check isAvailable key on simulator object
• FBJS: Upgrade to ^1.0.0
• ios-simulator: change default iphone version
• Bump metro@0.48.1
• Remove sinon dependency
• Update to Detox 9

[radeno]

@kelset plus three new:

• Fix InterpolatorType crash on Android
• Update React canary version
• Android ScrollView fix for snapToInterval

[grabbou]

Going to cherry-pick them later in the afternoon. Will be updating this thread shortly.

[elicwhite]

Let’s include the deprecation warning for ListView as well.
facebook/react-native@e90f5fa

[jeveloper]

@kelset Lorenzo , do i understand correctly, 57.3 will not have a fix for google build tools 3.2 or it will?

Thank you

[radeno]

@jeveloper even 0.58 doesn't have any support about new building system. It is still in progress facebook/react-native#21628
facebook/react-native#21632

[matthargett]

let's get these safe deprecation/warning commits in, as discussed on Slack:

• facebook/react-native@3aa8f09
• facebook/react-native@997f382
• facebook/react-native@8a2187b
• facebook/react-native@1fc8a46

[elicwhite]

@matthargett, two of those commits were listed by other people earlier up. The third one doesn't seem relevant it is changing an RNTester file. Did you mean to link to something else instead?

[grabbou]

All commits from this comment, this and this one have been cherry-picked.

Note: In order to cherry-pick Fix InterpolatorType crash on Android, I had to cherry-pick facebook/react-native@0df8e7d, facebook/react-native@69a51da and facebook/react-native@677f1de.

[kelset]

(reopening temporarily until I fix the release of 0.57.3)

[radeno]

@kelset these two commits missing:
first: facebook/react-native@d00bdb9 and then: facebook/react-native@4b6f02e
second is fix for first commit.

don't you want it in 0.57.3?

[kelset]

@jeveloper there is already a workaround in 0.57.2 (so the version of RN currently available should be able to work with Android Studio 3.2) -> facebook/react-native@a4fed6e

@radeno I didn't do the actual cherry-pick for release yesterday, probably it was overlooked. I'm fixing some CI issues atm, once everything is green again I'll try to get those in too.

[kelset]

Ok, 0.57.3 is out. Headsup, you need to update react and test-renderer to "16.6.0-alpha.8af6728" to have it work.