Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filterEnabled flag and don't enable filter if source is an hls playlist #1384

Merged
merged 6 commits into from
Dec 31, 2018

Conversation

nickgzzjr
Copy link
Contributor

This is an attempt to make the filter functionality easier to use and prevent sacrificing performance (when you don't need filters). I went ahead and added a filterEnabled flag which prevents/allows the filter to be set. Enabling filters from startup helps set filters on videos that have rotated orientation. Disabling filters prevent performance hits caused when using videoComposition.

I've also added a check to make sure that filters are not applied when the source is not an HLS playlist.

Lastly, I updated the basic example to showcase filters.

@nickgzzjr nickgzzjr changed the title filterEnabled & don't set filter if hls playlist Added filterEnabled flag & don't enable filter if source is an hls playlist Dec 14, 2018
@nickgzzjr nickgzzjr changed the title Added filterEnabled flag & don't enable filter if source is an hls playlist Added filterEnabled flag and don't enable filter if source is an hls playlist Dec 14, 2018
@cobarx cobarx merged commit b7a351c into TheWidlarzGroup:master Dec 31, 2018
beauner69 pushed a commit to beauner69/react-native-video that referenced this pull request Oct 10, 2019
Added filterEnabled flag and don't enable filter if source is an hls playlist

(rebased from commit b7a351c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants