disable airplay when sideloaded captions #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I would add a note in the textTracks docs covering this limitation so developers know to expect it. |
|
@cobarx note for textTracks issue with airplay added to readme. PR ready for merge. |
|
Thanks for making the change, I made a few slight tweaks to the wording to make it a bit more clear. Glad you got this fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For sideloaded captions on iOS, we have to use an AVMutableComposition. Unfortunately AVMutableComposition is not playable on Airplay. This code turns off video playback (sets external playback to false).
Additional check on textTracks also returns the default AVPlayerItem if textTracks is not null, but is empty.