Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowsExternalPlayback Property for ios #1057

Merged
merged 6 commits into from
Jun 10, 2018

Conversation

genglei01
Copy link
Contributor

Make the video control can disable allowsExternalPlayback for ios

Copy link
Contributor

@cobarx cobarx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Can you add an entry in the README for this prop.

ios/RCTVideo.m Outdated
@@ -67,6 +68,7 @@ - (instancetype)initWithEventDispatcher:(RCTEventDispatcher *)eventDispatcher
_controls = NO;
_playerBufferEmpty = YES;
_playInBackground = false;
_allowsExternalPlayback = YES;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is off here.

@genglei01
Copy link
Contributor Author

I have updated the README.

@cobarx
Copy link
Contributor

cobarx commented Jun 10, 2018

Thanks for updating this!

@cobarx cobarx merged commit bd30454 into TheWidlarzGroup:master Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants