Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add playWhileMuted property #310

Closed
mattapperson opened this issue Aug 30, 2016 · 8 comments
Closed

Add playWhileMuted property #310

mattapperson opened this issue Aug 30, 2016 · 8 comments
Labels
feature help wanted The issue has been reviewed and is valid, and is waiting for someone to work on it. Platform: iOS

Comments

@mattapperson
Copy link
Contributor

On iOS there are multiple AVAudioSessionCategory options for audio when playing a video.
We only really need to care about 2 of them, so we don't need to fully expose the API.

Issue:
Currently if the sound toggle switch is muted, the videos audio is muted.

Requested feature:
set [[AVAudioSession sharedInstance] setCategory:AVAudioSessionCategoryPlayback error:nil]; if playWhileMuted prop is set to true. default should be false.
@mattapperson mattapperson added feature help wanted The issue has been reviewed and is valid, and is waiting for someone to work on it. Good First PR Platform: iOS labels Aug 30, 2016
@mattapperson mattapperson changed the title Add playWhileMuted API Add playWhileMuted property Aug 30, 2016
@mattapperson mattapperson mentioned this issue Aug 30, 2016
Closed
@mattapperson
Copy link
Contributor Author

Note about this ticket added to readme

@duhseekoh duhseekoh mentioned this issue Dec 2, 2016
Merged
@anshul-kai
Copy link

anshul-kai commented Jan 7, 2017 •
edited

The suggestion to add [[AVAudioSession sharedInstance] setCategory:AVAudioSessionCategoryPlayback error:nil]; at the bottom of didFinishLaunchingWithOptions no longer seems to be working. Any ideas?

@zyonnetworks
Copy link

+1

@larryranches
Copy link

Any momentum on this feature?

@mattapperson
Copy link
Contributor Author

A PR was made here but needs work #403

@GeoffreyPlitt
Copy link

My company has created a $200 bounty for this issue. https://www.bountysource.com/issues/37409911-add-playwhilemuted-property

@duhseekoh
Copy link
Contributor

This ticket should be closed, given the merge of #403 .

@cobarx
Copy link
Contributor

cobarx commented Jun 3, 2018

Closing since merged.

@cobarx cobarx closed this as completed Jun 3, 2018
@paulrinaldi paulrinaldi mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature help wanted The issue has been reviewed and is valid, and is waiting for someone to work on it. Platform: iOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@larryranches @mattapperson @GeoffreyPlitt @duhseekoh @cobarx @zyonnetworks @anshul-kai