Defaults to the map services version instead of play services #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of now the googlePlayServicesMapsVersion variable defaults to "DEFAULT_GOOGLE_PLAY_SERVICES_VERSION" which is an unpublished version of maps - 16. 0.1, it needs to default to "DEFAULT_GOOGLE_PLAY_SERVICES_MAPS_VERSION" instead which is 16.0.0
|
@vincentvella thnx for the PR, is this working with the current git version (that's not yet published on npm) |
|
Yes, confirmed this change worked from the current master with my added change. Fixed our CI process @rborn . It seems like the defaulted variable in that file was defaulting maps-version to 16.0.1 instead of 16.0.0 (16.0.1 maps doesn't exist). |
Closed
asdolo
pushed a commit
to amalgamaco/react-native-maps
that referenced
this pull request
Sep 7, 2019
…native-maps#2653) As of now the googlePlayServicesMapsVersion variable defaults to "DEFAULT_GOOGLE_PLAY_SERVICES_VERSION" which is an unpublished version of maps - 16. 0.1, it needs to default to "DEFAULT_GOOGLE_PLAY_SERVICES_MAPS_VERSION" instead which is 16.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now the googlePlayServicesMapsVersion variable defaults to "DEFAULT_GOOGLE_PLAY_SERVICES_VERSION" which is an unpublished version of maps - 16. 0.1, it needs to default to "DEFAULT_GOOGLE_PLAY_SERVICES_MAPS_VERSION" instead which is 16.0.0
Does any other open PR do the same thing?
No, no other PR's have been submitted at the time of writing.
What issue is this PR fixing?
#2652
How did you test this PR?
Ran the sync before and after fixing with it symlinked, my PR fixes the issue with downloading the correct play services version.