Allow Specifying a different version for base and maps on android #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For use in cocoapods only projects
Update from master
Update react-native maps
update from master
Update from master
Salakar
approved these changes
Nov 16, 2018
rborn
reviewed
Nov 20, 2018
lib/android/build.gradle
Outdated
| def googlePlayServicesVersion = rootProject.hasProperty('googlePlayServicesVersion') ? rootProject.googlePlayServicesVersion : DEFAULT_GOOGLE_PLAY_SERVICES_VERSION | ||
| def androidMapsUtilsVersion = rootProject.hasProperty('androidMapsUtilsVersion') ? rootProject.androidMapsUtilsVersion : DEFAULT_ANDROID_MAPS_UTILS_VERSION | ||
| def googlePlayServicesVersion = rootProject.hasProperty('googlePlayServicesVersion') ? rootProject.googlePlayServicesVersion : DEFAULT_GOOGLE_PLAY_SERVICES_VERSION | ||
| // googlePlayServicesMapsVersion > googlePlayServicesVersion > DEFAULT_GOOGLE_PLAY_SERVICES_MAPS_VERSION (16.0.0) |
There was a problem hiding this comment.
do we need this commented code?
There was a problem hiding this comment.
It's not code, it was a comment so that people understand the line below. It can remove it completely
There was a problem hiding this comment.
Maybe you could make then more clear (more descriptive) or delete it, your call 😄
|
Well I could import his pr inside of mine if you want me to, or wait for his to be merged |
|
Sure thing 😄 |
|
hey guys, sorry for delay. sure thing mate @Titozzz go ahead 😃 |
|
Will do :) |
|
@rborn Done ✅ |
|
Still nothing ? 😢 |
|
@Titozzz sorry man, vacations + very busy, done now ❤️ |
|
Don't worry ❤️ This was part of emptying my github gigantic pile of notifications after vacations :D ! Thanks ! you can close #2584 |
asdolo
pushed a commit
to amalgamaco/react-native-maps
that referenced
this pull request
Sep 7, 2019
…act-native-maps#2587) * Fix Google map podspec For use in cocoapods only projects * Update react-native-google-maps.podspec * Update build.gradle * Update build.gradle * Update build.gradle * Update build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
#2584
How did you test this PR?
This allows android to specify a custom version for
com.google.android.gms : play-services-mapsand
com.google.android.gms : play-services-baseby specifying
for example I had to use 16.0.1 for base but maps does not exist for that version
https://mvnrepository.com/artifact/com.google.android.gms/play-services-maps
It should automatically fallback to googlePlayServicesVersion value if googlePlayServicesMapsVersion is not specified