Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dataindex allow array #1097

Merged
merged 2 commits into from
Apr 1, 2024
Merged

fix: dataindex allow array #1097

merged 2 commits into from
Apr 1, 2024

Conversation

pfdgithub
Copy link
Contributor

@pfdgithub pfdgithub commented Apr 1, 2024

fix: dataindex allow array

fix dataindex array
Copy link

vercel bot commented Apr 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 8:00am

@pfdgithub pfdgithub changed the title Update interface.ts fix: dataindex allow array Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.96%. Comparing base (7afff24) to head (d8eb3a6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1097   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files          51       51           
  Lines        4671     4671           
  Branches      592      592           
=======================================
  Hits         4576     4576           
  Misses         91       91           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ
Copy link
Member

zombieJ commented Apr 1, 2024

顺道把 number 也加上?

@crazyair
Copy link
Contributor

crazyair commented Apr 1, 2024

把 number 的也补充上吧

@crazyair
Copy link
Contributor

crazyair commented Apr 1, 2024

SpecialString SpecialNumber 会在 antd v6 大版本去掉。

src/interface.ts Outdated
@@ -69,7 +69,7 @@ export type Direction = 'ltr' | 'rtl';

export type SpecialString<T> = T | (string & {});

export type DataIndex<T = any> = DeepNamePath<T> | SpecialString<T>;
export type DataIndex<T = any> = DeepNamePath<T> | SpecialString<T> | SpecialString<T>[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加注释,SpecialString 在antd@6 去掉

@pfdgithub
Copy link
Contributor Author

done

@zombieJ zombieJ merged commit 173c116 into react-component:master Apr 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants