fix: should check sticky scroll bar visible when table height changed #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yoyo837
reviewed
Feb 4, 2024
linxianxi
force-pushed
the
fix-sticky-scrollbar
branch
from
e45b4f6
to
d8c8f9a
Compare
zombieJ
reviewed
Feb 5, 2024
zombieJ
reviewed
Feb 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1076 +/- ##
==========================================
+ Coverage 50.21% 50.26% +0.04%
==========================================
Files 97 97
Lines 9065 9074 +9
Branches 631 634 +3
==========================================
+ Hits 4552 4561 +9
Misses 4463 4463
Partials 50 50 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Feb 5, 2024
zombieJ
approved these changes
Feb 5, 2024
afc163
reviewed
Feb 5, 2024
| // The best way is to use ResizeObserver to detect the body height, but this way is enough | ||
| React.useEffect(() => { | ||
| checkScrollBarVisible(); | ||
| }, [data]); |
There was a problem hiding this comment.
data 放这里很容易触发的，如果写成字面量对象的。
改成 data.length 是不是就够了？
There was a problem hiding this comment.
这个方式已经很保守了，你说的这个，比如切换分页时，新的文本可能很长跟原来的差很多可能就有问题了。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ant-design/ant-design#47331
fix ant-design/ant-design#33762
结论：最好的方式是用 ResizeObserver 监听 table body 高度（会耗一些性能），但是目前做法也是够用
2024-02-04.16.28.54.mov