Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scroll.x not working when no fixed column exists #1023

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 19, 2023

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
table ✅ Ready (Inspect) Visit Preview Sep 19, 2023 2:56am

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1023 (c0e3d09) into master (aa2aa44) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c0e3d09 differs from pull request most recent head bf5a90f. Consider uploading reports for the commit bf5a90f to get more accurate results

@@           Coverage Diff           @@
##           master    #1023   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files          47       47           
  Lines        4426     4432    +6     
  Branches      559      559           
=======================================
+ Hits         4400     4406    +6     
  Misses         26       26           
Files Changed Coverage Δ
src/VirtualTable/index.tsx 100.00% <100.00%> (ø)
src/hooks/useColumns/useWidthColumns.tsx 98.92% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ zombieJ merged commit 4ffafff into master Sep 19, 2023
9 checks passed
@zombieJ zombieJ deleted the fix-col branch September 19, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual table horizontal scroll doesnt seem to work when scroll.x is set to true
1 participant