performance: cache children to improve performance (#426)

react-component · Apr 18, 2022 · 5e607ff · 5e607ff
1 parent 700ce5c
commit 5e607ff
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/Menu.tsx b/src/Menu.tsx
@@ -226,11 +226,11 @@ const Menu = React.forwardRef<MenuRef, MenuProps>((props, ref) => {
     ...restProps
   } = props as LegacyMenuProps;
 
-  const childList: React.ReactElement[] = parseItems(
-    children,
-    items,
-    EMPTY_LIST,
+  const childList: React.ReactElement[] = React.useMemo(
+    () => parseItems(children, items, EMPTY_LIST),
+    [children, items],
   );
+
   const [mounted, setMounted] = React.useState(false);
 
   const containerRef = React.useRef<HTMLUListElement>();