feat: support aria-labelledby and aria-describedby for dialog in Panel

[kapiljaveri]

The DrawerPanel has a dialog role which should support aria-labelledby and aria-describedby attributes.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
drawer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 6, 2024 5:34pm

[kapiljaveri]

@zombieJ if you can take a look when you get the chance :)

[afc163]

Conflicting

[kapiljaveri]

@afc163, all resolved.

[afc163]

We should change this line.

- {...pickAttrs(props, { data: true })}
+ {...pickAttrs(props, { data: true, aria: true })}

[kapiljaveri]

@afc163, won't that apply it to the container div instead of the Panel having the div with the role=dialog? The goal was to make the the dialog queryable via the attributes.

But I could definitely leverage that instead of my custom function.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4629910) 100.00% compared to head (69607ed) 100.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #425   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          148       148           
  Branches        53        53           
=========================================
  Hits           148       148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[afc163]

@kapiljaveri You are right.

[kapiljaveri]

Awesome, thanks for the review!