fix fitToSuppliedMarkers function #2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw: the bug got originally introduced here: #2479 |
|
@marcelkalveram do we need to adjust docs too? |
|
@rborn this doesn't work with Apple Maps (only Google, both Android and iOS), as mentioned in my previous PR. Not sure if this is something that should be mentioned in the docs? At least, after this PR, it shouldn't fail anymore with Apple Maps. |
|
We should mention that it only works with google maps or we'll get a lot of issues reported (it will be, trust me). |
|
@marcelkalveram I'll merge this |
This was referenced Oct 1, 2018
ryanbourneuk
pushed a commit
to 3sidedcube/react-native-maps
that referenced
this pull request
Dec 10, 2018
* upstream/master: (28 commits) Calculate bounding box from region (react-native-maps#2615) [iOS GoogleMap] Fix animateCamera (react-native-maps#2608) Fix type definition error (react-native-maps#2607) [Android] Fix app crash in Android if building found but cannot getActiveLevelIndex (react-native-maps#2598) Provide a camera system (react-native-maps#2563) Get visible map bounding box (react-native-maps#2571) [0.22.1] Release (react-native-maps#2574) Move dev only deps to devDependencies. (react-native-maps#2548) Specify how to use Google Maps (react-native-maps#2550) r2507: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference #: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference (react-native-maps#2555) update to clarify cacheEnabled is apple maps only [0.22.0] Release (react-native-maps#2535) Fix for “The specified child already has a parent” Improve installation docs (react-native-maps#2541) fix fitToSuppliedMarkers function (react-native-maps#2524) Performance improvements for tracksViewChanges (react-native-maps#2487) fix spelling mistakes Added flag to make sure that there has an Observer of view. hotfix PR react-native-maps#2478 Fix a peer dependencies warning ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2513
Does any other open PR do the same thing?
#2520
seems to fix the same issue
What issue is this PR fixing?
#2513
How did you test this PR?
iOS simulator. Builds were failing without this fix.