Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix peer dependencies warnings #2480

Merged

Conversation

junkpiano
Copy link
Contributor

@junkpiano junkpiano commented Sep 10, 2018

Does any other open PR do the same thing?

No.

What issue is this PR fixing?

This PR will fix peer dependencies warnings when you run npm install on the projects which are using React Native 0.56.0(or later). This relates to #2332 .

How did you test this PR?

in my project,

  • remove react-native-maps from package.json.
  • remove node_modules
  • run npm install again
  • run npm install <relative path to react-native-maps> --save
  • confirm warning messages related to react-native don't appear.

However, it doesn't solve the warning around @babel-core@7.0.0-beta.38(required by @babel/plugin-check-constants@7.0.0-beta.38).

- update peer dependencies
- modified version notation of react-native.
- use the release version of react
@rborn
Copy link
Collaborator

rborn commented Sep 10, 2018

LGTM @alvelig 🐽

@rborn
Copy link
Collaborator

rborn commented Sep 13, 2018

@alvelig ping ? 🤗

@alvelig alvelig merged commit d21749a into react-native-maps:master Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants