Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add edgePadding to fitToSuppliedMarkers function #2479

Merged
merged 1 commit into from
Sep 22, 2018

Conversation

marcelkalveram
Copy link
Contributor

@marcelkalveram marcelkalveram commented Sep 9, 2018

Does any other open PR do the same thing?

No.

What issue is this PR fixing?

Adds the edgePadding option to the fitToSuppliedMarkers function which is supported by Google Maps on both, iOS and Android. (no support for Apple Maps as the native function doesn't support this option).

The feature has been requested in those two issue and I had another use case on a personal project where I had to use a workaround using fitToCoordinates:
#780
#876

Another issue is requesting it for the function fitToElements which should be an easy addition if this PR gets accepted:
#922

How did you test this PR?

Tested on real devices: Android Pixel and iPhone 7.
Tested on iOS simulator: iPhone 6

@rborn
Copy link
Collaborator

rborn commented Sep 21, 2018

@marcelkalveram thank you ❤️

LGTM @alvelig 🐽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants