minSDK in manifest errors the compilation. Fixed #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When upgrading to newer gradle wrapper package versions that works with buildtools version 28+, error comes up if uses-sdk tag has "minSDK" property defined inside AndroidMainfest.xml file. Default SDK properties should stand only inside build.gradle files.
Fixed compiling with minSDK in manifest file error
…droidManifest.xml
|
Have the same issue with higher gradle version. Can You please merge this PR and release new version? |
|
@dkfl1995 how does this influence older sdks with older gradle? 🤗 |
|
It doesn't harm older sdks at all. I had been left minSDK version as it was earlier so, it couldn't let older sdks be broken |
|
LGTM @alvelig 🐽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No.
What issue is this PR fixing?
#2471
How did you test this PR?
Yes. I tried to recompile project on Android Studio with applied commit. (The steps are described in issue numbered above)