Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #2462

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Update package.json #2462

merged 1 commit into from
Sep 7, 2018

Conversation

Kennytian
Copy link
Contributor

@Kennytian Kennytian commented Aug 27, 2018

Fix packager.sh incorrect path in package.json

Does any other open PR do the same thing?

No.

What issue is this PR fixing?

No open issue fix, but fix on my computer, can be run 'yarn run:packager'

How did you test this PR?

I test this on Terminal, it's work.

Fix packager.sh incorrect path in package.json
@rborn
Copy link
Collaborator

rborn commented Sep 7, 2018

@Kennytian Thanks for the PR, can you find on what version of RN the path changed? If it's too early we'll have to wait a little with the merge.

@Kennytian
Copy link
Contributor Author

@rborn Thanks for your response.

On react native 0.46, Move packager launcher scripts outside of packager/, to scripts/

facebook/react-native@a710f9a

@rborn
Copy link
Collaborator

rborn commented Sep 7, 2018

@Kennytian ok, thanks, I think it's safe to merge 🤗

@rborn rborn merged commit cfd5790 into react-native-maps:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants