Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Prefix or eliminate globals in AIRMapMarker #2306

Merged

Conversation

terribleben
Copy link
Contributor

Does any other open PR do the same thing?

Not as far as I can tell

What issue is this PR fixing?

AIRMapMarker's implementation file contains a few global variables, some of which appear to be mistakes (they're being used as though they were instance variables of AIRMapMarker, so I made them actually be instance vars) and one which is a legitimate constant that I prefixed with AIR. These global symbols prevent the library from being vendored (e.g. for Expo) because they collide with other copies of the library. This solves that.

How did you test this PR?

Build the project and include it as a vendored library with other copies of itself.

expbot pushed a commit to expo/expo that referenced this pull request Jun 6, 2018
@terribleben terribleben merged commit e9618d4 into react-native-maps:master Jun 6, 2018
@terribleben terribleben deleted the @terribleben/prefix-globals branch June 6, 2018 20:11
timxyz pushed a commit to 3sidedcube/react-native-maps that referenced this pull request Aug 24, 2018
* master: (168 commits)
  Adding overlaying components details (react-native-maps#2425)
  docs: pin color limitations for android (react-native-maps#2429)
  Revert "Added MBTiles support for iOS and Android (react-native-maps#2208)" (react-native-maps#2387)
  Added MBTiles support for iOS and Android (react-native-maps#2208)
  Fix disabling the toolbar and my location button (react-native-maps#2317)
  Fixes warnings about self (react-native-maps#2341)
  Android: Fix lineCap of Polyline (react-native-maps#2375)
  Update installation.md (react-native-maps#2381)
  update doc (react-native-maps#2363)
  zIndex doesn't work when the map moves in iOS 11 (react-native-maps#2359)
  Fix readme formatting (react-native-maps#2358)
  add support for calloutAnchor with GoogleMaps on iOS; fixes react-native-maps#1852 (react-native-maps#2351)
  Added animateToNavigation method to MapView (react-native-maps#2049)
  Add react-native@^0.55 to peerDependencies (react-native-maps#2332)
  Fix custom marker updates on android react-native-maps#1611 react-native-maps#2048
  [iOS] Prefix or eliminate globals in AIRMapMarker (react-native-maps#2306)
  Fix CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF warnings (react-native-maps#2154)
  Fix for compile error (react-native-maps#2215). (react-native-maps#2232)
  Make tiles display at the same physical size regardless of pixel dens… (react-native-maps#2248)
  Added support of lineDashPattern polyline prop to iOS Google Maps (react-native-maps#2243)
  ...

# Conflicts:
#	lib/components/MapMarker.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant