Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tiles display at the same physical size regardless of pixel dens… #2248

Merged
merged 3 commits into from
May 13, 2018
Merged

Conversation

funkyfourier
Copy link
Contributor

…ity on iOS devices

Does any other open PR do the same thing?

Not that I know of.

What issue is this PR fixing?

#2242

How did you test this PR?

This makes UrlTile, when using Google Maps API, behave the same way on iOS as it currently does on Android. That is, displaying tiles at the same physical size regardless of pixel density.

Have tested on simulators iPhone X and iPhone 6, as well as a physical iPhone 5S device.

Here is a snack, which should also work without Expo: https://snack.expo.io/@jmr/urltile-ios-tile-size

Without my modification it will display the tiles very tiny on high dpi devices, and with the modification it will display them at the same size regardless.

@rborn
Copy link
Collaborator

rborn commented May 11, 2018

LGTM @alvelig

@alvelig
Copy link
Contributor

alvelig commented May 13, 2018

LGTM

@rborn rborn merged commit 29fb4a9 into react-native-maps:master May 13, 2018
timxyz pushed a commit to 3sidedcube/react-native-maps that referenced this pull request Aug 24, 2018
* master: (168 commits)
  Adding overlaying components details (react-native-maps#2425)
  docs: pin color limitations for android (react-native-maps#2429)
  Revert "Added MBTiles support for iOS and Android (react-native-maps#2208)" (react-native-maps#2387)
  Added MBTiles support for iOS and Android (react-native-maps#2208)
  Fix disabling the toolbar and my location button (react-native-maps#2317)
  Fixes warnings about self (react-native-maps#2341)
  Android: Fix lineCap of Polyline (react-native-maps#2375)
  Update installation.md (react-native-maps#2381)
  update doc (react-native-maps#2363)
  zIndex doesn't work when the map moves in iOS 11 (react-native-maps#2359)
  Fix readme formatting (react-native-maps#2358)
  add support for calloutAnchor with GoogleMaps on iOS; fixes react-native-maps#1852 (react-native-maps#2351)
  Added animateToNavigation method to MapView (react-native-maps#2049)
  Add react-native@^0.55 to peerDependencies (react-native-maps#2332)
  Fix custom marker updates on android react-native-maps#1611 react-native-maps#2048
  [iOS] Prefix or eliminate globals in AIRMapMarker (react-native-maps#2306)
  Fix CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF warnings (react-native-maps#2154)
  Fix for compile error (react-native-maps#2215). (react-native-maps#2232)
  Make tiles display at the same physical size regardless of pixel dens… (react-native-maps#2248)
  Added support of lineDashPattern polyline prop to iOS Google Maps (react-native-maps#2243)
  ...

# Conflicts:
#	lib/components/MapMarker.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants