Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Prefix DummyView class #2231

Merged

Conversation

terribleben
Copy link
Contributor

Does any other open PR do the same thing?

Nope

What issue is this PR fixing?

This class makes the library difficult to vendor because it has no AIR* class prefix. It's nice to keep this library easily vendorable so that we can make sure Expo always has the newest version.

How did you test this PR?

Rebuilt the native lib after renaming the class. There are no JS methods that reference this class.

@terribleben terribleben merged commit bdf6407 into react-native-maps:master May 1, 2018
@terribleben terribleben deleted the @terribleben/prefix-dummyview branch May 1, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant