Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color prop types #2217

Merged
merged 1 commit into from
May 1, 2018
Merged

Conversation

pedro
Copy link
Contributor

@pedro pedro commented Apr 26, 2018

Does any other open PR do the same thing?

No

What issue is this PR fixing?

Using react-native's ColorPropType to validate all color props more accurately.

More specifically I'm doing this to avoid getting yellow box alerts when using different formats for colors. For instance, using setNormalizedColorAlpha() I have colors defined as integers in my app.

How did you test this PR?

Just tested against my app, both in iOS and Android. Colors still work/no more alerts.

use react-native's ColorPropType to validate the input
@pedro
Copy link
Contributor Author

pedro commented Apr 26, 2018

Ah, worth noticing that ColorPropType is already used in MapView.js, so I don't think there are any concerns about compatibility with this change.

@rborn
Copy link
Collaborator

rborn commented May 1, 2018

LGTM @alvelig 🐽

@alvelig alvelig merged commit 16d373f into react-native-maps:master May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants