Fix overlay removal bug #2197
Merged
Fix overlay removal bug #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Could #2027 relate to it? |
|
@alvelig I don't really think so. This has a very specific and narrow use-case, and the issue you've linked does not even use any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
Nope
What issue is this PR fixing?
When
<Overlay/>component is unmounted before the image had a chance to load (either a large image, or slow internet connection), after image finishes loading overlay is still rendered, and cannot be removed afterwards.How did you test this PR?
There was a bug on Android which didn't cancel image rendering after removing from map. My change erases map reference, thus avoiding this bug.
Tested on several Android devices, does not seem to affect iOS.