Modifications/Enhancements to MapView.UrlTile #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ldReplaceMapContent) for iOS, MapKit only 2. Allow GoogleMaps on iOS to obey maximumZ 3. Added prop minimumZ for MapKit and GoogleMaps on iOS and Android
…ong to compare). Get rid of compiler warnings (accidentally wrote NSUInteger instead of NSInteger)
Add 'none' option to docs for mapType
…ct-native-maps#2172) * Add Mock Provider boolean on each location update * Update mapview.md Update docs to specify that coordinate includes mock provider boolean * Check API is 18 or above for isFromMockProvider * Update docs to mention API
…ldReplaceMapContent) for iOS, MapKit only 2. Allow GoogleMaps on iOS to obey maximumZ 3. Added prop minimumZ for MapKit and GoogleMaps on iOS and Android
…ong to compare). Get rid of compiler warnings (accidentally wrote NSUInteger instead of NSInteger)
|
LGTM @alvelig 🐽 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added propType shouldReplaceMapContent (effectively maps to canReplaceMapContent on MKTileOverlay) so that it's no longer hard coded to YES (is that a good default?) on iOS, MapKit.
Let GoogleMaps obey maximumZ (no longer just for iOS, MapKit!).
While we're at it, add a minimumZ for all maps on both platforms.
Does any other open PR do the same thing?
Not that I'm aware
What issue is this PR fixing?
N/A
How did you test this PR?
Tested on both simulators on a Mac