Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broader peer dependency support #2030

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Conversation

gabrielbull
Copy link
Contributor

This will remove warnings like this when installing:

warning " > react-native-maps@0.20.1" has incorrect peer dependency "react@16.0.0".
warning " > react-native-maps@0.20.1" has incorrect peer dependency "react-native@0.51.0".
warning " > react-native-maps@0.20.1" has unmet peer dependency "prop-types@^15.5.10".

This will remove warnings like this when installing:

```
warning " > react-native-maps@0.20.1" has incorrect peer dependency "react@16.0.0".
warning " > react-native-maps@0.20.1" has incorrect peer dependency "react-native@0.51.0".
warning " > react-native-maps@0.20.1" has unmet peer dependency "prop-types@^15.5.10".
```
@rborn
Copy link
Collaborator

rborn commented Feb 15, 2018

@gabrielbull thanks a lot for this, but could we use the correct semver syntax so 16.0.0 instead of 16.0 🤗

@gabrielbull
Copy link
Contributor Author

It is the correct syntax: https://docs.npmjs.com/misc/semver#caret-ranges-123-025-004

But I don't have time to argue so I'm closing the issue.

@rborn
Copy link
Collaborator

rborn commented Feb 15, 2018

@gabrielbull Why so angry ? 😔 I was wrong and I accept this, so no arguing from my side.

@gabrielbull gabrielbull reopened this Feb 15, 2018
@gabrielbull
Copy link
Contributor Author

Sorry, didn't mean to sound rude. I guess I'm just exhausted 😴. Thanks for being nice about this.

@rborn rborn merged commit 53b374b into react-native-maps:master Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants