Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript integration issues #233

Closed
cabello opened this issue Nov 16, 2021 · 2 comments
Closed

Typescript integration issues #233

cabello opened this issue Nov 16, 2021 · 2 comments

Comments

@cabello
Copy link

cabello commented Nov 16, 2021

Hi @josepot , how you doing? I hope you are doing great 😄

This is somewhat related to #228.

While doing minor release updates:
Screen Shot 2021-11-15 at 7 50 26 PM

My Typescript app broke:
Screen Shot 2021-11-15 at 7 50 54 PM

Apparently Typescript does not support mjs yet so webpack customization is required in this case: formatjs/formatjs#1395

Was that intentional? I.e. the fact that the library now breaks with Typescript?

Ideas, suggestions on how to bypass that? I think writing a custom rule saying mjs is still js is the most promising solution: formatjs/formatjs#1395 (comment)

Have a good one,

@josepot
Copy link
Member

josepot commented Nov 16, 2021

Hi @cabello !

Thanks for reporting this! I think that we addressed this issue already, but it looks like we forgot to publish the patch for @react-rxjs/utils@0.8.X. Could you please try using @react-rxjs/utils@0.9.3 (there shouldn't be any breaking changes...) and let us know if that solves the "compiling" issue? If it does, then I will publish a @react-rxjs/utils@0.8.4 patch for this issue.

Thanks again!

@voliva
Copy link
Collaborator

voliva commented Aug 21, 2023

As far as I know this issue has been fixed in the most recent versions of react-rxjs.

The exports definition on package.json was addressed in #302

@voliva voliva closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants