-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration changes ignore? #5
Comments
Hi there, thank u for letting me know. I'll fix it ASAP, then I'll give u updates |
Actually, I didn't notice any crash while rotating. would u please give me more info? where this happens ? |
I mean if you remove this line, the app would crash on rotation |
Do not remove whole line, just remove |
Actually your koin version is old so if you update your koin-compose you notice the crash with removing this line, its possibly due to the koin itself, probably using KoinApplication can cause it. Removing KoinApplicaion in compose and replacing it with startKoin on androidapplication would fix it though |
Thank u for letting me know, I'll check it. |
Shopping-By-KMP/androidApp/src/androidMain/AndroidManifest.xml
Line 22 in 62b3e26
Why this is added? If you remove this and try to rotate the device koin will cause a crash:
I don't think so ignoring configuration changes is a good idea.
The text was updated successfully, but these errors were encountered: