Configuration changes ignore?

[hulkdx]

Shopping-By-KMP/androidApp/src/androidMain/AndroidManifest.xml

Line 22 in 62b3e26

android:configChanges="orientation|screenSize|screenLayout|keyboardHidden|mnc|colorMode|density|fontScale|fontWeightAdjustment|keyboard|layoutDirection|locale|mcc|navigation|smallestScreenSize|touchscreen|uiMode"

Why this is added? If you remove this and try to rotate the device koin will cause a crash:

Caused by: org.koin.core.error.KoinAppAlreadyStartedException: Trying to run new Koin Application whereas Koin is already started. Use 'KoinContext()' instead of check for any 'startKoin' usage.

I don't think so ignoring configuration changes is a good idea.

[razaghimahdi]

Hi there, thank u for letting me know. I'll fix it ASAP, then I'll give u updates

[razaghimahdi]

Actually, I didn't notice any crash while rotating. would u please give me more info? where this happens ?

[hulkdx]

Actually, I didn't notice any crash while rotating. would u please give me more info? where this happens ?

I mean if you remove this line, the app would crash on rotation

[razaghimahdi]

Do not remove whole line, just remove orientation|

[hulkdx]

Actually your koin version is old so if you update your koin-compose you notice the crash with removing this line, its possibly due to the koin itself, probably using KoinApplication can cause it.

InsertKoinIO/koin#1884

Removing KoinApplicaion in compose and replacing it with startKoin on androidapplication would fix it though

[razaghimahdi]

Thank u for letting me know, I'll check it.