Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana 5.5.0 #8

Open
jamesspi opened this issue Jul 18, 2017 · 5 comments
Open

Kibana 5.5.0 #8

jamesspi opened this issue Jul 18, 2017 · 5 comments

Comments

@jamesspi
Copy link

Hi There!

Could you possibly look into making this compatible with 5.5.0?

Thanks,
James

@BoomerBrian
Copy link

+1. I tested it with 5.5.2 and it doesn't work

@pchanas
Copy link

pchanas commented Sep 19, 2017

html.js.zip

Same issue, solved by modifying package.json and html.js (my release attached).
Fix found following: https://discuss.elastic.co/t/kibana-plugin-api-4-n-5-n-webpack-errors-when-compiling-tutorial-plugin/98228

@GummyDonut
Copy link

To add to @pchanas file you can get the original syntax highlighting working if you take his file and add back the lines
require('plugins/kibana-html-plugin/deps/ace-builds/ace.js')
require('plugins/kibana-html-plugin/deps/ace-builds/mode-html.js');
require('plugins/kibana-html-plugin/deps/ace-builds/theme-monokai.js');
require('plugins/kibana-html-plugin/deps/angular-ui-ace/ui-ace.min.js');
above
require('plugins/kibana-html-plugin/html.less'); line

Then run bower install. https://github.com/rquadling/bower-installer. This is how raystorm originally pulled his dependencies into the public folder (code shown in bower.json). Then simply install the plugin like you would any normal plugin.
I'm curious if this will be updated, however until then this would be the solution to get syntax highlighting back.

@gwintzer
Copy link
Contributor

Hi.

I did the changes here (for Kibana 5.6.3) :
#10

For v5.5.0, just downgrade the kibana version from package.json and rebuild the plugin...

@jaydabhi17
Copy link

jaydabhi17 commented Oct 24, 2017

Hi

I have changed in this plugin to work with kibana 5.6.x.

I have changed html.js file as below(used import module in place of require module),

  import 'plugins/kibana-html-plugin/html.less';
  import 'plugins/kibana-html-plugin/htmlController';
  import { VisVisTypeProvider } from 'ui/vis/vis_type';
  import { TemplateVisTypeProvider } from 'ui/template_vis_type/template_vis_type';
  import { VisTypesRegistryProvider } from 'ui/registry/vis_types';

  VisTypesRegistryProvider.register(HtmlVisProvider);

  function HtmlVisProvider(Private) {
    const VisType = Private(VisVisTypeProvider);
    const TemplateVisType = Private(TemplateVisTypeProvider);

    return new TemplateVisType({
      name: 'html',
      title: 'Html widget',
      icon: 'fa-code',
      description: 'Useful for displaying html in dashboards.',
      category: VisType.CATEGORY.OTHER,
      template: require('plugins/kibana-html-plugin/html.html'),
      params: {
        editor: require('plugins/kibana-html-plugin/htmlOptions.html')
      },
      requiresSearch: false
    });
  }

export default HtmlVisProvider;

Hope this may be helpful for other versions.

raystorm-place pushed a commit that referenced this issue Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants