-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal.propTypes no longer supported in React Native 0.58 #14
Comments
@martin-nebel thank you! If the following script is added as a postinstall script, then running
|
Broke my app as well after upgrade... Fix? D: |
Broke mine too and the suggested fixes do not work either. |
@martin-nebel thank you for reporting this. I have created a new release with your suggested changes https://github.com/raynor85/react-native-modal-wrapper/releases/tag/v3.1.1 |
My components using ModalWrapper stopped working properly after updating to RN 0.58.x, because the Modal component no longer supports propTypes as per facebook/react-native#21342.
I'm not sure yet what the proper/best solution is to this, but as a temporary workaround to get my app's functionality working again, I included the Modal.propTypes values as a constant at the top of the component:
I then replaced the two occurrences of Modal.propTypes with modalPropTypes, after which it started working as expected.
The text was updated successfully, but these errors were encountered: