Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layout): impl Display for Position and Size #1162

Merged
merged 1 commit into from
Jun 4, 2024
Merged

feat(layout): impl Display for Position and Size #1162

merged 1 commit into from
Jun 4, 2024

Conversation

joshka
Copy link
Member

@joshka joshka commented Jun 3, 2024

No description provided.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (d7ed6c8) to head (b1b4b1c).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1162   +/-   ##
=====================================
  Coverage   94.2%   94.2%           
=====================================
  Files         60      60           
  Lines      14509   14522   +13     
=====================================
+ Hits       13670   13683   +13     
  Misses       839     839           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@EdJoPaTo EdJoPaTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use 13x37 for a Position too but its probably not that relevant.

As a downside… changing the Display implementation later on is probably a breaking change.

@joshka
Copy link
Member Author

joshka commented Jun 4, 2024

I would use 13x37 for a Position too but its probably not that relevant.

As a downside… changing the Display implementation later on is probably a breaking change.

Bikeshed comment, but hard disagree. (x, y) is pretty standard for things which are coordinates.

@joshka joshka merged commit 1520ed9 into main Jun 4, 2024
33 checks passed
@joshka joshka deleted the jm/display branch June 4, 2024 01:54
itsjunetime pushed a commit to itsjunetime/ratatui that referenced this pull request Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants