Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(padding): zero as a constant #1133

Merged
merged 2 commits into from
May 25, 2024

Conversation

EdJoPaTo
Copy link
Contributor

A const fn with no input is probably a constant.

-Padding::zero()
+Padding::ZERO

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.2%. Comparing base (cf67ed9) to head (0a8ee15).

Files Patch % Lines
src/widgets/block/padding.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1133     +/-   ##
=======================================
- Coverage   94.2%   94.2%   -0.1%     
=======================================
  Files         60      60             
  Lines      14630   14623      -7     
=======================================
- Hits       13790   13780     -10     
- Misses       840     843      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshka joshka merged commit 4f77910 into ratatui:main May 25, 2024
32 of 33 checks passed
@EdJoPaTo EdJoPaTo deleted the padding-zero-constant branch May 25, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants