Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Make failed patches fatal #699

Open
Jacobfaib opened this issue Oct 2, 2024 · 0 comments
Open

[FEA] Make failed patches fatal #699

Jacobfaib opened this issue Oct 2, 2024 · 0 comments
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@Jacobfaib
Copy link
Contributor

Currently, when a patch fails, rapids-cmake will log the failure under $CMAKE_BUILD_DIR/rapids-cmake/<the-dep>/log and silently continue. Sometimes, however, it is vital that a patch succeed and in this case it is useful to immediately error out at configure-time to alert the developer of the failing patch.

For example, the versions.json spec could be updated to incorporate such a feature per patch:

"<some_package>" : {
  "patches" : [
    {
      "file" : ...
      "required" : true, # false by default
    }
  ]
}
@Jacobfaib Jacobfaib added ? - Needs Triage Need team to review and classify feature request New feature or request labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant