Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notices to ALL #316

Closed
Tracked by #318
robertmaynard opened this issue Dec 1, 2022 · 2 comments · Fixed by #339
Closed
Tracked by #318

Add deprecation notices to ALL #316

robertmaynard opened this issue Dec 1, 2022 · 2 comments · Fixed by #339
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@robertmaynard
Copy link
Contributor

robertmaynard commented Dec 1, 2022

Is your feature request related to a problem? Please describe.
To enforce consumers to use RAPIDS add deprecation notices when a project uses the older magic values.

Describe the solution you'd like
Large CMake deprecation warning that this will be released in the N+1 version of rapids-cmake with documentation on how to fix.
Would use message(AUTHOR_WARNING

@robertmaynard
Copy link
Contributor Author

Note that they will be removed in 23.06 so users have sufficient time to update all CI / release scripts

@robertmaynard robertmaynard changed the title [FEA] Add deprecation notices to ALL and "" Add deprecation notices to ALL and "" Dec 1, 2022
@robertmaynard robertmaynard changed the title Add deprecation notices to ALL and "" Add deprecation notices to ALL Dec 1, 2022
@robertmaynard
Copy link
Contributor Author

We need to be careful when we run into nested projects that all use rapids-cmake but of different versions ( 22.10 vs 23.02 ).

In those cases we need to preserve backwards compat, so functions like rapids_cuda_set_architectures need to behave in a 22.10 mode.

I believe that we can check the rapids-cmake-version value and switch to old behavior when needed ( with extra notifications about updating to latest rapids-cmake version ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant