Remove numba dependency #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numba-cuda is the NVIDIA-maintained CUDA target for Numba, which depends on the numba package. This PR replaces the numba dependency with numba-cuda. However, similar to @bdice's comment in rapidsai#648, I don't know if we strictly need this here any more due to the cudf dependency (from rapidsai/cudf#16474) ensuring numba-cuda is present.
|
I think we can delete the dependencies that come transitively from RAPIDS repositories. Let’s remove the numba pins here. |
gmarkall
commented
Aug 5, 2024
gmarkall
commented
Aug 5, 2024
As suggested by @bdice in rapidsai#715, since the dependency comes transitively from cuDF.
|
@bdice Many thanks for the suggestion - I think I've implemented it as you suggested (and updated the title / description) |
bdice
approved these changes
Aug 5, 2024
|
@gmarkall I think this might be ready to merge if you agree. I merged the upstream since CI was failing. |
|
@bdice I think this should be fine as the dependency comes from cudf (and will come from its numba-cuda dependency once rapidsai/cudf#16474 is merged). |
|
I updated this PR and retargeted to 24.12. I will give it a |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: This now removes the numba dependency, which comes transitively from cuDF.
Original description:
numba-cuda is the NVIDIA-maintained CUDA target for Numba, which depends on the numba package.
This PR replaces the numba dependency with numba-cuda. However, similar to @bdice's comment in #648, I don't know if we strictly need this here any more due to the cudf dependency (from rapidsai/cudf#16474) ensuring numba-cuda is present.