Add to_dlpack/from_dlpack APIs to pylibcudf #17055
Open
+148
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
improvement
vyasr
requested changes
Oct 22, 2024
| Table with a copy of the tensor data. | ||
| """ | ||
| cdef unique_ptr[table] c_result | ||
| cdef DLManagedTensor* dlpack_tensor = <DLManagedTensor*>PyCapsule_GetPointer( |
There was a problem hiding this comment.
We should add some of the safety checks from https://dmlc.github.io/dlpack/latest/python_spec.html#implementation to ensure that we don't try to consume an already deleted capsule or anything like that.
There was a problem hiding this comment.
Added one check, lmk if you were thinking of any others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #15162
Could use some advice how to type the input of
from_dlpackand outut ofto_dlpackwhich are PyCapsule objects.EDIT: I notice Cython just types them as object https://github.com/cython/cython/blob/master/Cython/Includes/cpython/pycapsule.pxd. Stylistically do we want add
object var_nameor just leave untyped?Checklist