Make CategoricalColumn.__init__ strict #16456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
vyasr
approved these changes
Aug 16, 2024
| and isinstance(children[0], cudf.core.column.numerical.NumericalColumn) | ||
| and children[0].dtype.kind in "iu" | ||
| ): | ||
| # TODO: Enforce unsigned integer? |
There was a problem hiding this comment.
Does it need to be? This would be removing the i in quotes above, I assume.
There was a problem hiding this comment.
I guess it doesn't strictly need to be since libcudf will probably do that casting if needed. And yeah we would just remove the i
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR transfers some of the validation logic in
build_columndirectly intoCategoricalColumnjust in caseCategoricalColumnis called independently ofbuild_column. Additionally adds stricter validation ofdata,dtypeandchildrenso the column doesn't represent an invalid statexref #16469
Checklist