Remove checking for specific tests in memcheck script #16412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
bdice
approved these changes
Jul 26, 2024
harrism
reviewed
Jul 29, 2024
| @@ -50,6 +50,8 @@ CUDF_KERNEL void test_kernel(int* data) { data[threadIdx.x] = threadIdx.x; } | |||
| // calls. | |||
| TEST(StreamCheck, FailedKernel) | |||
| { | |||
| if (getenv("LIBCUDF_MEMCHECK_ENABLED")) { return; } | |||
There was a problem hiding this comment.
perhaps we should use GTEST_SKIP() rather than just returning?
Suggested change
| if (getenv("LIBCUDF_MEMCHECK_ENABLED")) { return; } | |
| if (getenv("LIBCUDF_MEMCHECK_ENABLED")) { GTEST_SKIP(); } |
There was a problem hiding this comment.
Ok. This works in this file but not in the test_default_stream_identification.cu since that one is not actually a gtest.
harrism
approved these changes
Jul 31, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the checking for specific gtests in the
run_cudf_memcheck_ctests.shscript. Each of those tests can check theLIBCUDF_MEMCHECK_ENABLEDenvironment variable themselves.This simplifies the script logic and may help with replacing this with ctest logic in the future.
Checklist