Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up state variables in MultiIndex #16203

Merged
merged 15 commits into from
Jul 12, 2024

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Jul 5, 2024

Description

MultiIndex sets it's own state variables outside of __init__ and allows some uninitialized private variables that may be called in other methods. This PR now ensures these state variables are always initialized in __init__, _from_data and _simple_new

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change cuDF (Python) labels Jul 5, 2024
@mroeschke mroeschke requested a review from a team as a code owner July 5, 2024 22:21
@mroeschke mroeschke requested review from vyasr and lithomas1 July 5, 2024 22:21
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 5, 2024
@mroeschke mroeschke changed the title Move MultiIndex.from_frame implementation to MultiIndex._from_data Clean up state variables in MultiIndex Jul 9, 2024
@lithomas1
Copy link
Contributor

Hm, I haven't really used MultiIndexes before, so probably not the best person to review here.

@galipremsagar Do you want to take a look at this one?

@lithomas1 lithomas1 removed their request for review July 10, 2024 15:48
@galipremsagar galipremsagar self-requested a review July 10, 2024 23:33
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 390e6fe into rapidsai:branch-24.08 Jul 12, 2024
86 checks passed
@mroeschke mroeschke deleted the ref/mi/from_frame branch July 12, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants