Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor from_arrow_device/host to use resource_ref #16160

Merged

Conversation

harrism
Copy link
Member

@harrism harrism commented Jul 2, 2024

Description

Fixes #16159

Also fixes typos / leftovers in dictionary add_keys copydocs.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism requested a review from a team as a code owner July 2, 2024 02:00
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 2, 2024
@harrism harrism added bug Something isn't working breaking Breaking change labels Jul 2, 2024
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, #15904 (which was based on the PRs adding the code that this fixed) proliferated the issue (and introduced the conflicts here). When resolving conflicts, could you fix the from_arrow_stream API as well? I'll be careful to correctly handle the mrs in future PRs.

cpp/include/cudf/interop.hpp Outdated Show resolved Hide resolved
@harrism
Copy link
Member Author

harrism commented Jul 3, 2024

Can't see why the docs build is failing. Warnings only:

/opt/conda/envs/docs/lib/python3.11/site-packages/cudf/core/dataframe.py:docstring of cudf.core.dataframe.DataFrame.to_csv:35: WARNING: py:data reference target not found: os.linesep

/opt/conda/envs/docs/lib/python3.11/site-packages/cudf/core/indexed_frame.py:docstring of cudf.core.indexed_frame.IndexedFrame.to_hdf:71: WARNING: py:func reference target not found: open
/opt/conda/envs/docs/lib/python3.11/site-packages/cudf/core/indexed_frame.py:docstring of cudf.core.indexed_frame.IndexedFrame.to_hdf:71: WARNING: py:func reference target not found: open
/opt/conda/envs/docs/lib/python3.11/site-packages/cudf/core/column/string.py:docstring of cudf.core.column.string.StringMethods.istitle:6: WARNING: py:meth reference target not found: str.istitle
/opt/conda/envs/docs/lib/python3.11/site-packages/cudf/core/column/string.py:docstring of cudf.core.column.string.StringMethods.join:5: WARNING: py:meth reference target not found: str.join
/opt/conda/envs/docs/lib/python3.11/site-packages/cudf/core/column/string.py:docstring of cudf.core.column.string.StringMethods.rsplit:49: WARNING: py:obj reference target not found: str.split
/opt/conda/envs/docs/lib/python3.11/site-packages/cudf/core/column/string.py:docstring of cudf.core.column.string.StringMethods.rsplit:51: WARNING: py:obj reference target not found: str.rsplit
/opt/conda/envs/docs/lib/python3.11/site-packages/cudf/core/column/string.py:docstring of cudf.core.column.string.StringMethods.split:50: WARNING: py:obj reference target not found: str.split
/opt/conda/envs/docs/lib/python3.11/site-packages/cudf/core/column/string.py:docstring of cudf.core.column.string.StringMethods.split:52: WARNING: py:obj reference target not found: str.rsplit
/opt/conda/envs/docs/lib/python3.11/site-packages/cudf/io/hdf.py:docstring of cudf.io.hdf.read_hdf:10: WARNING: py:class reference target not found: pathlib.Path
/opt/conda/envs/docs/lib/python3.11/site-packages/cudf/io/hdf.py:docstring of cudf.io.hdf.read_hdf:46: WARNING: py:func reference target not found: open

@harrism
Copy link
Member Author

harrism commented Jul 3, 2024

/merge

@rapids-bot rapids-bot bot merged commit 39de5a2 into rapidsai:branch-24.08 Jul 3, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] from_arrow_device and from_arrow_host should take device_async_resource_ref, not device_memory_resource*
4 participants