-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor from_arrow_device/host to use resource_ref #16160
Refactor from_arrow_device/host to use resource_ref #16160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies, #15904 (which was based on the PRs adding the code that this fixed) proliferated the issue (and introduced the conflicts here). When resolving conflicts, could you fix the from_arrow_stream
API as well? I'll be careful to correctly handle the mrs in future PRs.
Can't see why the docs build is failing. Warnings only:
|
/merge |
Description
Fixes #16159
Also fixes typos / leftovers in dictionary
add_keys
copydocs.Checklist