-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid index-to-column conversion in some DataFrame ops #15763
Avoid index-to-column conversion in some DataFrame ops #15763
Conversation
python/cudf/cudf/core/dataframe.py
Outdated
other.index.to_pandas() | ||
) | ||
) | ||
and not ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to revert my suggestion, because from the diff I thought everything below was inside this if
block, but they are outside of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had to move the walrus condition to the top so the if
branch doesn't short circuit without defining these variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the condition looked to have done the trick and all green here
/merge |
Description
xref #15494
Index.str
, check thedtype
instead of the underlying column type (which would materialize RangeIndex)set_index
, don't immediately convert passed objects to column until necessary_make_operands_and_index_for_binop
, don't create pandas object more than onceChecklist