Replace RangeIndex._start/_stop/_step with _range #15576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
vyasr
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Nice little improvement. I left one suggestion that I think is worth implementing and one question, but I went ahead and approved since I don't think I need to look at this again once you address the suggestion (the helper function) if you think it makes sense.
galipremsagar
approved these changes
Apr 22, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
._start/_stop/_stepattributes are wholly redundant with the similar attributes on arangeobject, so replacing with those attributes where neededChecklist