Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large strings support for cudf::clamp #15533

Merged
merged 7 commits into from
May 2, 2024
Merged

Large strings support for cudf::clamp #15533

merged 7 commits into from
May 2, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Apr 15, 2024 •
edited
Loading

Description

Replaces call to make_strings_children utility to use the gather-based make_strings_column function which is already optimized for long strings (and large strings).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 15, 2024
@davidwendt davidwendt self-assigned this Apr 15, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 15, 2024
@davidwendt davidwendt marked this pull request as ready for review April 22, 2024 18:21
@davidwendt davidwendt requested a review from a team as a code owner April 22, 2024 18:21
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e58838b into rapidsai:branch-24.06 May 2, 2024
70 checks passed
@davidwendt davidwendt deleted the ls-clamp branch May 2, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@pmattione-nvidia pmattione-nvidia Awaiting requested review from pmattione-nvidia

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @bdice @karthikeyann @pmattione-nvidia