Disable pandas 2.x clipboard tests in cudf.pandas tests #15462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
pandas
improvement
galipremsagar
approved these changes
Apr 9, 2024
raydouglass
approved these changes
Apr 10, 2024
galipremsagar
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Can we see if the time increase is really reasonable or unexpected?
Pandas-tests job took 25 mins in previous PRs: https://github.com/rapidsai/cudf/actions/runs/8620421542/job/23629341145
But this PR seems to have spiked to 34 mins, almost 10mins increase: https://github.com/rapidsai/cudf/actions/runs/8620734650/job/23634860081?pr=15462
Is it because of the apt install? or the pytest execution ?
|
Sorry for the delay here. I decided to just disable the clipboard tests all together. I don't think we can reliably get these tests to run since the tests do some monkeypatching that crashes pytest workers. |
mroeschke
changed the title
|
@galipremsagar should be ready for a second look |
galipremsagar
approved these changes
May 14, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clipboard testing currently
ERRORsince apytest-qtfixture isn't found.Even when this fixture is installed these tests seems to consistent crash pytest workers (I suspect since there is some method patching in
test_clipboard.py. I don't thinkcudf.pandasshould realistically work with clipboard functionality so just skipping these tests insteadChecklist