Cleanup some timedelta/datetime column logic #14715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
wence-
reviewed
Jan 9, 2024
| def __contains__(self, item: ScalarLike) -> bool: | ||
| try: | ||
| item_as_dt64 = np.datetime64(item, self._time_unit) | ||
| item_as_dt64 = np.datetime64(item, self.time_unit) |
There was a problem hiding this comment.
nit If self.dtype is a DatetimeTZDtype is this code correct?
There was a problem hiding this comment.
Good find, no it doesn't. In pandas least for DatetimeTZDtype, item must be tz-aware and the same UTC time to return True.
In [1]: import pandas as pd
In [2]: dti = pd.date_range("2020", periods=3, tz="UTC")
In [3]: pd.Timestamp("2020") in dti
Out[3]: False
In [4]: pd.Timestamp("2020", tz="UTC") in dti
Out[4]: True
In [5]: pd.Timestamp("2020", tz="US/Pacific") in dti
Out[5]: False
In [6]: pd.Timestamp("2019-12-31T16:00:00", tz="US/Pacific") in dti
Out[6]: TrueThere was a problem hiding this comment.
Fixed this case and added a unit test
|
@wence- could you take another look at this PR? |
|
@wence- when you have a moment could you re-review this PR? |
… into ref/column/cleanups
shwina
approved these changes
Apr 4, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove private
_time_unitattribute in favor of the public one and perform dtype validation earlier in__init__Checklist