Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly pass .dtype into is_foo_dtype functions #14657

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Explicitly pass .dtype into is_foo_dtype functions #14657

merged 1 commit into from
Jan 11, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Just promotes more explicitness when using dtype checking functions

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 20, 2023
@mroeschke mroeschke requested a review from a team as a code owner December 20, 2023 00:24
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 516559e into rapidsai:branch-24.02 Jan 11, 2024
67 checks passed
@mroeschke mroeschke deleted the ref/is_foo_dtype2 branch January 11, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @vyasr