Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of namespaces in parquet code. #14259

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Cleanup of namespaces in parquet code. #14259

merged 4 commits into from
Oct 9, 2023

Conversation

nvdbaranec
Copy link
Contributor

@nvdbaranec nvdbaranec commented Oct 6, 2023 •
edited
Loading

Cleans up several issues in the parquet code:

  • We were using the namespace cudf::io::detail::parquet, when cudf::io::parquet::detail makes more sense.
  • Converts the cudf::io::parquet::gpu namespace to also just use cudf::io::parquet::detail
  • Several detail-style headers and source files were using cudf::io::parquet when they should probably have been in the detail namespace.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@nvdbaranec
Cleanup of namespaces in parquet. The ::detail::parquet namespace has…
8907a90 
… been changed to ::parquet::detail, ::parquet::gpu has been renamed to ::parquet::detail, and several detail-style files which

were just using ::parquet have been moved into parquet::detail.
@nvdbaranec nvdbaranec added code quality libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue labels Oct 6, 2023
@nvdbaranec nvdbaranec requested a review from a team as a code owner October 6, 2023 16:08
@nvdbaranec nvdbaranec added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Oct 6, 2023
PointKernel
PointKernel approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vuule vuule self-requested a review October 6, 2023 20:10
vuule
vuule requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking up this task. Gets rid of so many gpu::!

cpp/src/io/parquet/reader_impl.cpp Outdated Show resolved Hide resolved
cpp/src/io/parquet/reader_impl.hpp Outdated Show resolved Hide resolved
cpp/src/io/parquet/parquet_common.hpp Outdated Show resolved Hide resolved
cpp/src/io/parquet/reader_impl.hpp Outdated Show resolved Hide resolved
cpp/src/io/functions.cpp Show resolved Hide resolved
cpp/src/io/parquet/predicate_pushdown.cpp Outdated Show resolved Hide resolved
cpp/src/io/utilities/column_buffer.cpp Outdated Show resolved Hide resolved
cpp/src/io/utilities/column_buffer.cpp Outdated Show resolved Hide resolved
cpp/src/io/utilities/column_buffer.cpp Outdated Show resolved Hide resolved
cpp/src/io/utilities/column_buffer.cpp Outdated Show resolved Hide resolved
@nvdbaranec nvdbaranec requested a review from vuule October 6, 2023 22:07
@nvdbaranec
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e28017c into rapidsai:branch-23.12 Oct 9, 2023
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@PointKernel PointKernel PointKernel approved these changes

@vuule vuule vuule approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nvdbaranec @bdice @PointKernel @vuule