Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable indexalator for device code #14206

Merged
merged 15 commits into from
Oct 17, 2023
Merged

Enable indexalator for device code #14206

merged 15 commits into from
Oct 17, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Sep 27, 2023 •
edited
Loading

Description

Enables indexalator to be instantiated from device code.
Also add gtests for the output indexalator.
This change helps enable for the offset-normalizing-iterator #14234

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 27, 2023
@davidwendt davidwendt self-assigned this Sep 27, 2023
@GregoryKimball GregoryKimball mentioned this pull request Sep 27, 2023
Closed
@davidwendt davidwendt mentioned this pull request Sep 28, 2023
Merged
3 tasks
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 6, 2023
@davidwendt davidwendt marked this pull request as ready for review October 10, 2023 11:48
@davidwendt davidwendt requested a review from a team as a code owner October 10, 2023 11:48
bdice
bdice approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise LGTM.

cpp/include/cudf/detail/normalizing_iterator.cuh Outdated Show resolved Hide resolved
PointKernel
PointKernel approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cpp/include/cudf/detail/normalizing_iterator.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/detail/normalizing_iterator.cuh Outdated Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5f05c18 into rapidsai:branch-23.12 Oct 17, 2023
60 checks passed
@davidwendt davidwendt deleted the indexalator-device-enable branch October 17, 2023 15:32
rapids-bot bot pushed a commit that referenced this pull request Nov 13, 2023
@davidwendt
Normalizing offsets iterator (#14234)
04d13d8 
Creates a normalizing offsets iterator that returns an int64 value given either a int32 or int64 column data.
Depends on #14206

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - Yunsong Wang (https://github.com/PointKernel)

URL: #14234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@PointKernel PointKernel PointKernel approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @PointKernel