Skip to content

Commit

Permalink
Update TODOs from issue 10432. (#12528)
Browse files Browse the repository at this point in the history
This removes/updates some `TODO` comments from the code after discussions on issue #10432 with @davidwendt.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Nghia Truong (https://github.com/ttnghia)

URL: #12528
  • Loading branch information
bdice authored Jan 11, 2023
1 parent f990f93 commit 2e86077
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
4 changes: 2 additions & 2 deletions cpp/src/reductions/segmented_reductions.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2022, NVIDIA CORPORATION.
* Copyright (c) 2022-2023, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -88,7 +88,7 @@ struct segmented_reduce_dispatch_functor {
col, offsets, output_dtype, null_handling, init, stream, mr);
default:
CUDF_FAIL("Unsupported aggregation type.");
// TODO: Add support for compound_ops
// TODO: Add support for compound_ops. GH #10432
}
}
};
Expand Down
5 changes: 1 addition & 4 deletions cpp/src/reductions/simple_segmented.cuh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2022, NVIDIA CORPORATION.
* Copyright (c) 2022-2023, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -73,8 +73,6 @@ std::unique_ptr<column> simple_segmented_reduction(
rmm::cuda_stream_view stream,
rmm::mr::device_memory_resource* mr)
{
// TODO: Rewrites this function to accept a pair of iterators for start/end indices
// to enable `2N` type offset input.
// reduction by iterator
auto dcol = cudf::column_device_view::create(col, stream);
auto simple_op = Op{};
Expand All @@ -99,7 +97,6 @@ std::unique_ptr<column> simple_segmented_reduction(
make_fixed_width_column(result_type, num_segments, mask_state::UNALLOCATED, stream, mr);
auto outit = result->mutable_view().template begin<ResultType>();

// TODO: Explore rewriting null_replacing_element_transformer/element_transformer with nullate
if (col.has_nulls()) {
auto f = simple_op.template get_null_replacing_element_transformer<ResultType>();
auto it = thrust::make_transform_iterator(dcol->pair_begin<InputType, true>(), f);
Expand Down

0 comments on commit 2e86077

Please sign in to comment.