Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3: Tooltip styling has changed #12126

Closed
yonasberhe23 opened this issue Oct 4, 2024 · 8 comments · Fixed by #12172
Closed

Vue3: Tooltip styling has changed #12126

yonasberhe23 opened this issue Oct 4, 2024 · 8 comments · Fixed by #12172
Assignees
Labels
area/vue3 kind/bug QA/manual-test Indicates issue requires manually testing
Milestone

Comments

@yonasberhe23
Copy link
Contributor

Setup

  • Rancher version: v2.10
  • Rancher UI Extensions:
  • Browser type & version: Firefox, Chrome

Describe the bug
Tooltip style has changed.

To Reproduce

  1. go to Rancher home page > hover over side nav button
  2. go to Explorer > hover over header buttons
  3. go to Explorer > workloads > hover over flat list/group by ns buttons

Result
Screenshot 2024-10-03 at 9 34 08 PM

Expected Result
Screenshot 2024-10-03 at 9 35 14 PM

@yonasberhe23 yonasberhe23 added this to the v2.10.0 milestone Oct 4, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Oct 4, 2024
@cnotv cnotv self-assigned this Oct 4, 2024
@cnotv
Copy link
Contributor

cnotv commented Oct 4, 2024

Placement modifiers are not honored, I suspect some hacks have truncated any definition: https://floating-vue.starpad.dev/guide/directive#placement-modifier

@cnotv
Copy link
Contributor

cnotv commented Oct 7, 2024

Tooltip also broken for main navigation bar.

2.10
Screenshot 2024-10-07 at 23 39 38

2.9
Screenshot 2024-10-07 at 23 40 43

@cnotv
Copy link
Contributor

cnotv commented Oct 7, 2024

Probably every tooltip is broken in the current state. This is for labels:

Screenshot 2024-10-08 at 00 01 22

@cnotv
Copy link
Contributor

cnotv commented Oct 8, 2024

@eva-vashkevich @mantis-toboggan-md I see a lot of AKS/EKS/GKE use cases for the tooltip. May I ask you to confirm the default style is the right one? It would mean arrow center bottom.

@cnotv
Copy link
Contributor

cnotv commented Oct 8, 2024

This issue is a regression of existing changes which have been reported and fixed with:

All these cases have to be tested afterward. Trying to identify the regression PR at this point, although refactoring in a single file only would be optimal.

@rak-phillip
Copy link
Member

rak-phillip commented Oct 8, 2024

Hmm I'm finding this to be quite confusing - it appears that commit 1bc3507 is the first one to exhibit this behavior. Are you finding the same?

edit: #12172 narrowed it down to a typo, good catch!

@cnotv cnotv added QA/manual-test Indicates issue requires manually testing and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Oct 8, 2024
@mantis-toboggan-md
Copy link
Member

@eva-vashkevich @mantis-toboggan-md I see a lot of AKS/EKS/GKE use cases for the tooltip. May I ask you to confirm the default style is the right one? It would mean arrow center bottom.

Yes AKS/EKS/GKE should use default tooltip styling

@yonasberhe23 yonasberhe23 self-assigned this Oct 9, 2024
@yonasberhe23
Copy link
Contributor Author

The tooltip issues have been resolved throughout Dashboard except for resource lists. (#12197)

Tested in:
Rancher v2.10-8b50f8332866224f855d0d5daa535c98bc9a2f6d-head
Dashboard master 9b3c6ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vue3 kind/bug QA/manual-test Indicates issue requires manually testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants