Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to Action in the footer #29

Open
siddhant36 opened this issue Oct 19, 2021 · 13 comments
Open

Call to Action in the footer #29

siddhant36 opened this issue Oct 19, 2021 · 13 comments
Assignees
Labels

Comments

@siddhant36
Copy link

siddhant36 commented Oct 19, 2021

@everly-gif There should be a call to action of Email id and phone number. If we click on any of these it should redirect to the respective apps. Please assign me to take up this task

Reference of mine:

@everly-gif
Copy link
Collaborator

hi @siddhant36 Right now we don't have a footer. So do you mind making a footer and adding the CTA's?
Please don't use any cdn as it breaks the template
check for overflow issues before you submit the PR
Just a simple footer will do
If this is okay for you, I'll assign this issue to you

@siddhant36
Copy link
Author

@everly-gif Yes, I will add a footer section for the portfolio which will match the template's style and contain all the CTA buttons. Please assign me this task

@everly-gif
Copy link
Collaborator

@siddhant36 go ahead!

@Pranjal7852
Copy link
Contributor

@everly-gif I have made the PR request containing Footer with CTA. Please have a look and let me know if it served the cause.
 
#60
image

@everly-gif
Copy link
Collaborator

everly-gif commented Oct 21, 2021

@Pranjal7852 Issues are given first come first serve basis. @siddhant36 claimed it before you and hence only his PR can be accepted with this issue. Please refer the README.md and follow that from next time :) However, if he is unresponsive then we can reassign it to you and your PR can be accepted.

@everly-gif
Copy link
Collaborator

everly-gif commented Oct 21, 2021

@siddhant36 please submit the PR within today by the end of the day. Will be reassigning it tomorrow to @Pranjal7852 if no progress @rajmunkhan keep up with this issue's progress and reassign it tomorrow if necessary.

@rajmunkhan rajmunkhan assigned Pranjal7852 and unassigned siddhant36 Oct 22, 2021
@rajmunkhan
Copy link
Owner

@Pranjal7852 this issue is assigned to u, r u up for it? I saw your PR but it has some conflicts, also I need some changes there, can we talk about it?

@Pranjal7852
Copy link
Contributor

I am ready to work do let me know the changes to be made

@rajmunkhan
Copy link
Owner

@everly-gif I have made the PR request containing Footer with CTA. Please have a look and let me know if it served the cause.   #60 image

from this deesign, remove the connect with me H2, keep only the icons, and also don't keep the icons so separated from each other. Keep them closer in middle.

@Pranjal7852
Copy link
Contributor

@rajmunkhan I have the changes as per your request do check it out.
#60
 
image

@rajmunkhan
Copy link
Owner

@Pranjal7852 it looks cool but your PR has conflicts, do u know how to fix them?

The steps are:

  1. fetch upstream from this repo to your repo
  2. pull the changes to your local computer
  3. change the conflicting code
  4. give PR to me again

@Pranjal7852
Copy link
Contributor

I will try my best

@siddhant36
Copy link
Author

Sorry was inactive due to some personal reasons. Getting back to work now could I still take part in solving any other issue @rajmunkhan . I would like to contribute to the portfolio project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants